ZTE-EBASE commented on code in PR #1226:
URL: https://github.com/apache/cloudberry/pull/1226#discussion_r2211917419
##########
src/include/fstream/gfile.h:
##########
@@ -103,4 +127,11 @@ void gfile_printf_then_putc_newline(const char*format,...)
pg_attribute_printf(1
void*gfile_malloc(size_t size);
void gfile_free(void*a);
+#ifdef LIBSSH2
Review Comment:
In file included from url_file.c:21:
../../../../src/include/fstream/gfile.h:75:9: error: unknown type name
‘LIBSSH2_SESSION’
75 | LIBSSH2_SESSION *session;
| ^~~~~~~~~~~~~~~
../../../../src/include/fstream/gfile.h:76:9: error: unknown type name
‘LIBSSH2_SFTP’
76 | LIBSSH2_SFTP *sftp_session;
| ^~~~~~~~~~~~
../../../../src/include/fstream/gfile.h:77:9: error: unknown type name
‘LIBSSH2_SFTP_HANDLE’
77 | LIBSSH2_SFTP_HANDLE *sftp_handle;
| ^~~~~~~~~~~~~~~~~~~
#ifdef LIBSSH2
#include <libssh2.h>
#include <libssh2_sftp.h>
#endif
It's clear that there is no dependency on the libssh2 library. There are
header files, but that's it. As mentioned earlier, you said that you would
check for the existence of LIBSSH2 through --enable-gpfdist. Does that mean
it's up to me to control it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
