yjhjstz commented on code in PR #1226:
URL: https://github.com/apache/cloudberry/pull/1226#discussion_r2217129512


##########
configure.ac:
##########
@@ -225,6 +225,15 @@ PGAC_ARG_BOOL(enable, gpfdist, yes,
              [do not use gpfdist])
 AC_SUBST(enable_gpfdist)
 
+if test "$enable_gpfdist" = yes; then
+  # Check libssh2 >= 1.0.0
+  PKG_CHECK_MODULES([LIBSSH2], [libssh2 >= 1.0.0],
+    [AC_DEFINE([LIBSSH2], [1], [Define if libssh2 is available])],
+    [AC_MSG_ERROR([libssh2 >= 1.0.0 is required for gpfdist support])]

Review Comment:
   ```sql
   PKG_CHECK_MODULES([LIBSSH2], [libssh2 >= 1.0.0],
     [AC_DEFINE([LIBSSH2], [1], [Define if libssh2 is available])],
     [AC_MSG_WARN([libssh2 >= 1.0.0 not found, gpfdist will build without 
libssh2 support])]
   )
   ```
   
   If libssh2 is not found, only a warning is issued (AC_MSG_WARN), the macro 
is not defined, and the configure process does not fail.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to