gfphoenix78 commented on code in PR #1324:
URL: https://github.com/apache/cloudberry/pull/1324#discussion_r2305856461
##########
contrib/pax_storage/src/cpp/storage/filter/pax_sparse_pg_path.cc:
##########
@@ -57,6 +57,23 @@ void PaxSparseFilter::Initialize(List *quals) {
fl_nodes.emplace_back(std::move(fl_node));
}
+ // walk scan key and only support min/max filter now
+ for (int i = 0; i < nkeys; i++) {
+ // TODO: support bloom filter in PaxFilter
+ // but now just skip it, SeqNext() will check bloom filter in
PassByBloomFilter()
+ if (key[i].sk_flags & SK_BLOOM_FILTER) {
+ continue;
+ }
+
+ if (key[i].sk_strategy != BTGreaterEqualStrategyNumber &&
+ key[i].sk_strategy != BTLessEqualStrategyNumber) {
Review Comment:
Can't process column filters with `sk_strategy = BTEqualStrategyNumber`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org
For additional commands, e-mail: commits-h...@cloudberry.apache.org
