leborchuk commented on code in PR #1324:
URL: https://github.com/apache/cloudberry/pull/1324#discussion_r2310135310
##########
contrib/pax_storage/src/cpp/storage/filter/pax_sparse_pg_path.cc:
##########
@@ -57,6 +57,23 @@ void PaxSparseFilter::Initialize(List *quals) {
fl_nodes.emplace_back(std::move(fl_node));
}
+ // walk scan key and only support min/max filter now
+ for (int i = 0; i < nkeys; i++) {
Review Comment:
We add ProcessScanKey nodes after the ExprWalker nodes. Does this mean
ExprWalker are executed before ProcessScanKey? If so, maybe it would be cheaper
to execute the ProcessScanKey first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org
For additional commands, e-mail: commits-h...@cloudberry.apache.org
