tuhaihe commented on code in PR #1757: URL: https://github.com/apache/cloudberry/pull/1757#discussion_r3280030918
########## gpcontrib/gp_relsizes_stats/src/gp_relsizes_stats.c: ########## Review Comment: Please add the standard ASF license header. Can take this for a reference: https://github.com/apache/cloudberry/blob/d4f437bcd90b44897aee7d10fa627c899aa79262/gpcontrib/gp_stats_collector/src/gp_stats_collector.c#L1-L26 ########## gpcontrib/gp_relsizes_stats/LICENCE: ########## Review Comment: I think we can remove this file. ########## gpcontrib/gp_relsizes_stats/test/expected/gp_relsizes_stats.out: ########## Review Comment: Could you enable the tests in the `.github/workflows` CI workflows files for this new extension? Then we can see if it can build/run well in the test env. ########## gpcontrib/gp_relsizes_stats/Makefile: ########## @@ -0,0 +1,20 @@ +MODULE_big = gp_relsizes_stats +OBJS = ./src/gp_relsizes_stats.o +EXTENSION = gp_relsizes_stats +EXTVERSION = 1.3 +DATA = $(wildcard sql/*--*.sql) +REGRESS = grants gp_relsizes_stats +REGRESS_OPTS = --inputdir=test/ +PGFILEDESC = "gp_relsizes_stats - an extension to track table on-disc sizes in greenplum" Review Comment: +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
