tuhaihe commented on PR #1757: URL: https://github.com/apache/cloudberry/pull/1757#issuecomment-4571216871
Hi @Vladislav, Thank you for your work. Here are my comments for your consideration: 1. Please re-import the commit history into the `gpcontrib/***` directory instead of placing it in the root directory -- from the first commit, though moving the files to gpcontrib at last. This change will help prevent conflicts with the top source code files in Cloudberry when rebasing the PR. 2. It would be beneficial to clean up the commit history. You can refer to this PR for guidance: https://github.com/apache/cloudberry/pull/1629. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
