tuhaihe commented on PR #1752: URL: https://github.com/apache/cloudberry/pull/1752#issuecomment-4507069191
> > For managing the new submodule, we can introduce it in the same way discussed here: [#1084 (review)](https://github.com/apache/cloudberry/pull/1084#pullrequestreview-2813295236) > > Yes, I did as was described. The issue is that there is no stored tag information and the tag is an ephemeral entity shown only in the `git submodule` output. See > > ``` > xifos@xifos-dev-jammy:~/git/cloudberry-leborchuk$ git submodule status > 0da57b85cf23e48d0e515f58c65a25425dbde012 contrib/pax_storage/src/cpp/contrib/googlebench (v1.9.2-3-g0da57b8) > 52204f78f94d7512df1f0f3bea1d47437a2c3a58 contrib/pax_storage/src/cpp/contrib/googletest (release-1.8.0-3536-g52204f78) > 3a58301067bbc03da89ae5a51b3e05b7da719d38 contrib/pax_storage/src/cpp/contrib/tabulate (v1.3-51-g3a58301) > 61c03f62b370b685b7994830b570a88d05ba15ab dependency/yyjson (0.10.0-20-g61c03f6) > a09ea700d32bab83325aff9ff34d0582e50e3997 gpcontrib/gpcloud/test/googletest (release-1.8.0-2358-ga09ea700) > 0d88f66a5fd0dba82681eef5929529cb153cb325 gpcontrib/yezzey (1.8.8) > ``` > > Here yezzey linked with `1.8.8` tag but the link info is still commit hash. If I delete tag `git submodule ` just shows commit hash without tag info Hi, you're right. It looks good now. Here is my cmd list: ``` cd cloudberry/ git submodule add https://github.com/open-gpdb/yezzey.git gpcontrib/yezzey git submodule status cd gpcontrib/yezzey/ git fetch --tags git tag --list git checkout tags/1.8.8 cd .. git add gpcontrib/yezzey/ git commit -m "Add yezzey to v1.8.8. xxxxx" ``` Never mind. We can add the version number info in the commit history when upgrading it next time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
