tuhaihe commented on code in PR #1752:
URL: https://github.com/apache/cloudberry/pull/1752#discussion_r3297635161
##########
gpcontrib/Makefile:
##########
@@ -40,6 +40,9 @@ endif
ifeq "$(with_gp_stats_collector)" "yes"
recurse_targets += gp_stats_collector
endif
+ifeq "$(with_yezzey)" "yes"
+ recurse_targets += yezzey
Review Comment:
```suggestion
recurse_targets += yezzey
```
##########
.github/workflows/yezzey-ci.yaml:
##########
@@ -0,0 +1,334 @@
+# --------------------------------------------------------------------
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed
+# with this work for additional information regarding copyright
+# ownership. The ASF licenses this file to You under the Apache
+# License, Version 2.0 (the "License"); you may not use this file
+# except in compliance with the License. You may obtain a copy of the
+# License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+# implied. See the License for the specific language governing
+# permissions and limitations under the License.
+#
+# --------------------------------------------------------------------
+# Yezzey CI Workflow
+# --------------------------------------------------------------------
+name: Yezzey CI Pipeline
+
+on:
+ push:
+ branches: [ main ]
+ pull_request:
+ types: [opened, synchronize, reopened, edited]
+ workflow_dispatch:
+
+permissions:
+ contents: read
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
+
+env:
+ CLOUDBERRY_HOME: "/usr/local/cloudberry-db"
+ CLOUDBERRY_VERSION: "main"
+
+jobs:
+
+ ## Stage 1: Build artifacts and run tests for cloudberry
+
+ test-cloudberry:
+ name: Build and Test Yezzey Cloudberry
+ runs-on: ubuntu-latest
+ container:
+ image: apache/incubator-cloudberry:cbdb-build-ubuntu22.04-latest
Review Comment:
Could we add the Rocky 8/9 docker image to the test matrix?
##########
configure.ac:
##########
@@ -1395,6 +1395,13 @@ if test "$with_zstd" = yes; then
PKG_CHECK_MODULES([ZSTD], [libzstd >= 1.4.0])
fi
+#
+# yezzey
Review Comment:
Hi, does yezzey need some extra dependencies for building? If so, we also
need to add the pre-check for them when running `configure --with-yezzey`.
##########
.github/workflows/yezzey-ci.yaml:
##########
@@ -0,0 +1,334 @@
+# --------------------------------------------------------------------
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed
+# with this work for additional information regarding copyright
+# ownership. The ASF licenses this file to You under the Apache
+# License, Version 2.0 (the "License"); you may not use this file
+# except in compliance with the License. You may obtain a copy of the
+# License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+# implied. See the License for the specific language governing
+# permissions and limitations under the License.
+#
+# --------------------------------------------------------------------
+# Yezzey CI Workflow
+# --------------------------------------------------------------------
+name: Yezzey CI Pipeline
+
+on:
+ push:
+ branches: [ main ]
+ pull_request:
+ types: [opened, synchronize, reopened, edited]
+ workflow_dispatch:
+
+permissions:
+ contents: read
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
+
+env:
+ CLOUDBERRY_HOME: "/usr/local/cloudberry-db"
+ CLOUDBERRY_VERSION: "main"
+
+jobs:
+
+ ## Stage 1: Build artifacts and run tests for cloudberry
+
+ test-cloudberry:
+ name: Build and Test Yezzey Cloudberry
+ runs-on: ubuntu-latest
+ container:
+ image: apache/incubator-cloudberry:cbdb-build-ubuntu22.04-latest
+ options: >-
+ --user root
+ -h cdw
+ -v /usr/share:/host_usr_share
+ -v /usr/local:/host_usr_local
+ -v /opt:/host_opt
+
+ services:
+ # Define the MinIO service container
+ minio:
+ image: lazybit/minio # Use a specific MinIO image tag
+ ports:
+ - 9000:9000 # Expose MinIO's API port (9000)
+ - 9001:9001 # Expose MinIO's console port (optional, for web UI)
+ env:
+ # MinIO root credentials (required for admin access)
+ MINIO_ROOT_USER: some_key
+ MINIO_ROOT_PASSWORD: some_key
+ # Healthcheck to ensure MinIO is ready before the job proceeds
+ options: >-
+ --name minio
+ --health-cmd "curl --fail http://localhost:9000/minio/health/live";
+ --health-interval 10s
+ --health-timeout 5s
+ --health-retries 5
+ volumes:
+ - ${{ github.workspace }}/data:/data
+
+ steps:
+ - name: Checkout Cloudberry source
+ uses: actions/checkout@v4
+ with:
+ path: cloudberry
+ submodules: true
+
+ - name: Checkout Yproxy source
+ uses: actions/checkout@v4
+ with:
+ repository: open-gpdb/yproxy
+ ref: master
+ path: yproxy
+
+ - name: Cloudberry Environment Initialization
+ shell: bash
+ env:
+ LOGS_DIR: build-logs
+ SRC_DIR: ${{ github.workspace }}/cloudberry
+ run: |
+ set -eo pipefail
+ if ! su - gpadmin -c "/tmp/init_system.sh"; then
+ echo "::error::Container initialization failed"
+ exit 1
+ fi
+
+ mkdir -p "${SRC_DIR}/build-logs"
+ chown -R gpadmin:gpadmin "${SRC_DIR}/build-logs"
+ mkdir -p "${LOGS_DIR}/details"
+ chown -R gpadmin:gpadmin .
+ chmod -R 755 .
+ chmod 777 "${LOGS_DIR}"
+
+ df -kh /
+ rm -rf /__t/*
+ df -kh /
+
+ df -h | tee -a "${LOGS_DIR}/details/disk-usage.log"
+ free -h | tee -a "${LOGS_DIR}/details/memory-usage.log"
+
+ {
+ echo "=== Environment Information ==="
+ uname -a
+ df -h
+ free -h
+ env
+ } | tee -a "${LOGS_DIR}/details/environment.log"
+
+ echo "SRC_DIR=${GITHUB_WORKSPACE}" | tee -a "$GITHUB_ENV"
+
+ - name: Install MinIO Client (mc)
+ run: |
+ set -ex pipefail
Review Comment:
```suggestion
set -exo pipefail
```
##########
.github/workflows/yezzey-ci.yaml:
##########
@@ -0,0 +1,334 @@
+# --------------------------------------------------------------------
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed
+# with this work for additional information regarding copyright
+# ownership. The ASF licenses this file to You under the Apache
+# License, Version 2.0 (the "License"); you may not use this file
+# except in compliance with the License. You may obtain a copy of the
+# License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+# implied. See the License for the specific language governing
+# permissions and limitations under the License.
+#
+# --------------------------------------------------------------------
+# Yezzey CI Workflow
+# --------------------------------------------------------------------
+name: Yezzey CI Pipeline
+
+on:
+ push:
+ branches: [ main ]
+ pull_request:
+ types: [opened, synchronize, reopened, edited]
+ workflow_dispatch:
+
+permissions:
+ contents: read
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
+
+env:
+ CLOUDBERRY_HOME: "/usr/local/cloudberry-db"
+ CLOUDBERRY_VERSION: "main"
+
+jobs:
+
+ ## Stage 1: Build artifacts and run tests for cloudberry
+
+ test-cloudberry:
+ name: Build and Test Yezzey Cloudberry
+ runs-on: ubuntu-latest
+ container:
+ image: apache/incubator-cloudberry:cbdb-build-ubuntu22.04-latest
+ options: >-
+ --user root
+ -h cdw
+ -v /usr/share:/host_usr_share
+ -v /usr/local:/host_usr_local
+ -v /opt:/host_opt
+
+ services:
+ # Define the MinIO service container
+ minio:
+ image: lazybit/minio # Use a specific MinIO image tag
Review Comment:
Do we need to specify a tag for this image?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
