This is an automated email from the ASF dual-hosted git repository. avamingli pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit e4bf9dac8dfcaaec7767675572a6ee2d9e1a76ec Author: Zhang Mingli <[email protected]> AuthorDate: Thu May 28 23:23:05 2026 +0800 numeric: drop bogus 'const' qualifier on init_var_from_str The prototype in src/include/utils/numeric.h declared the function as returning 'const bool', which conflicts with the definition in numeric.c that returns plain 'bool'. gcc tolerates this (const on a non-pointer return is silently meaningless), but clang flags it as 'conflicting types' and the build fails on macOS. Introduced by '#392 Export numeric interface to public'. Match the .c definition: plain 'bool'. --- src/include/utils/numeric.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/include/utils/numeric.h b/src/include/utils/numeric.h index d175e858879..5cb94e509b6 100644 --- a/src/include/utils/numeric.h +++ b/src/include/utils/numeric.h @@ -317,8 +317,8 @@ extern void free_numeric_var(NumericVar *var); extern void alloc_numeric_var(NumericVar *var, int ndigits); extern void zero_numeric_var(NumericVar *var); -extern const bool init_var_from_str(const char *str, const char *cp, NumericVar *dest, const char **endptr, - Node *escontext); +extern bool init_var_from_str(const char *str, const char *cp, NumericVar *dest, const char **endptr, + Node *escontext); extern void init_var_from_var(const NumericVar *value, NumericVar *dest); extern void init_ro_var_from_var(const NumericVar *value, NumericVar *dest); extern void set_var_from_num(Numeric value, NumericVar *dest); --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
