This is an automated email from the ASF dual-hosted git repository. avamingli pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit 344bac8fa420f31ad9e5749f7b00fd0431ae7b73 Author: Zhang Mingli <[email protected]> AuthorDate: Fri May 29 19:06:48 2026 +0800 ic_udpifc: fix initSndBufferPool forward declaration The forward declaration at line 838 was static void initSndBufferPool(); which under C's old K&R rules means 'function with unspecified arguments' — but the actual definition takes a SendBufferPool *: static void initSndBufferPool(SendBufferPool *p) and the single caller at line 3677 passes &snd_buffer_pool. gcc silently accepts the mismatch; Apple clang correctly rejects it under -Wdeprecated-non-prototype. C2x will reject it on every compiler. Match the forward declaration to the definition. --- contrib/interconnect/udp/ic_udpifc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/interconnect/udp/ic_udpifc.c b/contrib/interconnect/udp/ic_udpifc.c index 8e54be4c30d..be14218f168 100644 --- a/contrib/interconnect/udp/ic_udpifc.c +++ b/contrib/interconnect/udp/ic_udpifc.c @@ -835,7 +835,7 @@ static void sendOnce(ChunkTransportState *transportStates, ChunkTransportStateEn static inline uint64 computeExpirationPeriod(MotionConn *conn, uint32 retry); static ICBuffer *getSndBuffer(MotionConn *conn); -static void initSndBufferPool(); +static void initSndBufferPool(SendBufferPool *p); static void putIntoUnackQueueRing(UnackQueueRing *uqr, ICBuffer *buf, uint64 expTime, uint64 now); static void initUnackQueueRing(UnackQueueRing *uqr); --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
