chenjinbao1989 opened a new pull request, #123: URL: https://github.com/apache/cloudberry-pxf/pull/123
pxfuriparser.c and pxf_option.c used the generic Value node type for option-name strings; PG16 split Value into distinct Integer/Float/String/ etc. node types, and makeString()/strVal() now operate on String *, so these failed to compile with "unknown type name 'Value'". gpdbwritableformatter.c called htonl/ntohl/htons/ntohs without including arpa/inet.h. This used to be a silent implicit-declaration warning but is a hard error under GCC 13's -Werror=implicit-function-declaration. <!--Thank you for contributing! --> <!--In case of an existing issue or discussions, please reference it--> closes: #ISSUE_Number <!--Remove this section if no corresponding issue.--> --- ## Change logs > Describe your change clearly, including what problem is being solved or what document is being added or updated. ## Contributor's checklist Here are some reminders before you submit your pull request: * Make sure that your Pull Request has a clear title and commit message. You can take the [Git commit template](https://github.com/apache/cloudberry/blob/main/.gitmessage) as a reference. * Learn the [code contribution](https://cloudberry.apache.org/contribute/code) and [doc contribution](https://cloudberry.apache.org/contribute/doc) guides for better collaboration. * Make sure that CICD workflow is successful. * List your communications in the [GitHub Issues](https://github.com/apache/cloudberry-pxf/issues) or [Discussions](https://github.com/apache/cloudberry/discussions) (if has or needed). * Feel free to ask for the [cloudberry committers](https://github.com/orgs/apache/teams/cloudberry-committers) or other people to help review and approve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
