tuhaihe opened a new pull request, #2000:
URL: https://github.com/apache/cloudberry/pull/2000
The clients target copies the shell script that sets GPHOME_CLIENTS into the
package it assembles:
cp -f client/scripts/greenplum_$@_path$(SCRIPT) $(CLIENTSINSTLOC)/
With $@ expanding to "clients" and SCRIPT to ".sh" that resolves to
client/scripts/greenplum_clients_path.sh, which does not exist. The file was
renamed to cloudberry_clients_path.sh during the rebranding and this reference
was not updated with it, so the target would fail here if anyone reached it.
Nobody has: the top-level GNUmakefile deliberately steps over
gpAux/Makefile, and the body of the clients target is skipped unless
BLD_TARGETS contains "clients", which nothing in the tree sets. So this is a
latent break rather than a live one, and fixing it costs a word.
Verified with `make -C gpAux -n clients BLD_TARGETS=clients` on Rocky 9.
Before, the expanded command reads
cp -f client/scripts/greenplum_clients_path.sh ...
and after
cp -f client/scripts/cloudberry_clients_path.sh ...
which matches the file in the tree and copies successfully when run from
gpAux/, the directory make uses.
Note that gpMgmt/bin/gpload, gpload.py and gpdirtableload still look for
greenplum_loaders_path.sh under $GPHOME_LOADERS. Those are deliberate
compatibility lookups against a separately installed Greenplum loaders package,
not references to anything in this repository, so they are left alone.
Assisted-by: Claude Code
Backpatch-through: REL_2_STABLE
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
Fixes #ISSUE_Number
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution
guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] This PR contains AI-assisted code generation
- [ ] Requested review from [cloudberry
committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list:
[[email protected]](https://lists.apache.org/[email protected])
(subscribe: [email protected])
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
