CLOUDSTACK-2071 - VirtualMachineManagerImpl.java start() method for instance can fail to start a VM without notifying caller, if no exception is triggered. The result is that VM start looks successful but was not. This fixes it by throwing an exception at the very end if the object to be passed back is still null.
Signed-off-by: Marcus Sorensen <mar...@betterservers.com> 1366225829 -0600 Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/8d0bea99 Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/8d0bea99 Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/8d0bea99 Branch: refs/heads/internallb Commit: 8d0bea994dcd74cd6707b58ac2e4060a93f52d96 Parents: 9584815 Author: Marcus Sorensen <mar...@betterservers.com> Authored: Wed Apr 17 13:10:29 2013 -0600 Committer: Marcus Sorensen <mar...@betterservers.com> Committed: Wed Apr 17 13:13:05 2013 -0600 ---------------------------------------------------------------------- .../com/cloud/vm/VirtualMachineManagerImpl.java | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cloudstack/blob/8d0bea99/server/src/com/cloud/vm/VirtualMachineManagerImpl.java ---------------------------------------------------------------------- diff --git a/server/src/com/cloud/vm/VirtualMachineManagerImpl.java b/server/src/com/cloud/vm/VirtualMachineManagerImpl.java index 4072531..a53e380 100755 --- a/server/src/com/cloud/vm/VirtualMachineManagerImpl.java +++ b/server/src/com/cloud/vm/VirtualMachineManagerImpl.java @@ -866,6 +866,11 @@ public class VirtualMachineManagerImpl extends ManagerBase implements VirtualMac } } + if (startedVm == null) { + throw new CloudRuntimeException("Unable to start instance '" + vm.getHostName() + + "' (" + vm.getUuid() + "), see management server log for details"); + } + return startedVm; }
