Updated Branches: refs/heads/master ab6bf0b20 -> a1a68ed0c
Review 11752 applied Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/a1a68ed0 Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/a1a68ed0 Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/a1a68ed0 Branch: refs/heads/master Commit: a1a68ed0c4b722f6f83733d0b110debde2a1041e Parents: ab6bf0b Author: Alex Huang <[email protected]> Authored: Mon Jun 10 16:07:05 2013 -0700 Committer: Alex Huang <[email protected]> Committed: Mon Jun 10 16:07:05 2013 -0700 ---------------------------------------------------------------------- utils/src/com/cloud/utils/Ternary.java | 2 +- utils/test/com/cloud/utils/TernaryTest.java | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cloudstack/blob/a1a68ed0/utils/src/com/cloud/utils/Ternary.java ---------------------------------------------------------------------- diff --git a/utils/src/com/cloud/utils/Ternary.java b/utils/src/com/cloud/utils/Ternary.java index fee69ee..115d0f4 100644 --- a/utils/src/com/cloud/utils/Ternary.java +++ b/utils/src/com/cloud/utils/Ternary.java @@ -61,7 +61,7 @@ public class Ternary<T, U, V> { @Override public boolean equals(Object obj) { - if (!(obj instanceof Pair)) { + if (!(obj instanceof Ternary)) { return false; } Ternary<?, ?, ?> that = (Ternary<?, ?, ?>)obj; http://git-wip-us.apache.org/repos/asf/cloudstack/blob/a1a68ed0/utils/test/com/cloud/utils/TernaryTest.java ---------------------------------------------------------------------- diff --git a/utils/test/com/cloud/utils/TernaryTest.java b/utils/test/com/cloud/utils/TernaryTest.java new file mode 100644 index 0000000..ec1c2f9 --- /dev/null +++ b/utils/test/com/cloud/utils/TernaryTest.java @@ -0,0 +1,18 @@ +package com.cloud.utils; + +import org.junit.Assert; +import org.junit.Test; + +public class TernaryTest { + @Test + public void testEquals() { + Assert.assertEquals(new Ternary<String, String, String>("a", "b", "c"), new Ternary<String, String, String>( + "a", "b", "c")); + Assert.assertFalse(new Ternary<String, String, String>("a", "b", "c") + .equals(new Ternary<String, String, String>("a", "b", "d"))); + Assert.assertFalse(new Ternary<String, String, String>("a", "b", "c").equals("")); + Assert.assertFalse(new Ternary<String, String, String>("a", "b", "c").equals(null)); + Assert.assertFalse(new Ternary<String, String, String>("a", "b", "c") + .equals(new Pair<String, String>("a", "b"))); + } +}
