Spaceman1984 commented on a change in pull request #4640:
URL: https://github.com/apache/cloudstack/pull/4640#discussion_r571963127
##########
File path: api/src/main/java/com/cloud/storage/StorageService.java
##########
@@ -104,4 +104,6 @@
ImageStore updateImageStoreStatus(Long id, Boolean readonly);
+ void syncHardwareCapability(long poolId);
Review comment:
Done
##########
File path:
engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
##########
@@ -207,6 +215,13 @@ protected boolean filter(ExcludeList avoid, StoragePool
pool, DiskProfile dskCh,
return false;
}
+ if (diskProvisioningTypeStrictness){
+ StoragePoolDetailVO hardwareAcceleration =
storagePoolDetailsDao.findDetail(pool.getId(), "hardwareAccelerationSupported");
Review comment:
Done
##########
File path:
engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
##########
@@ -207,6 +215,13 @@ protected boolean filter(ExcludeList avoid, StoragePool
pool, DiskProfile dskCh,
return false;
}
+ if (diskProvisioningTypeStrictness){
+ StoragePoolDetailVO hardwareAcceleration =
storagePoolDetailsDao.findDetail(pool.getId(), "hardwareAccelerationSupported");
+ if (!dskCh.getProvisioningType().equals("thin") &&
hardwareAcceleration == null ||
!hardwareAcceleration.getValue().equals("true")){
Review comment:
Done
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -5260,6 +5272,17 @@ protected Answer execute(ModifyStoragePoolCommand cmd) {
}
}
+ private boolean
getHardwareAcceleationSupportForDataStore(ManagedObjectReference host, String
dataStoreName) throws Exception {
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
