Spaceman1984 commented on a change in pull request #4640:
URL: https://github.com/apache/cloudstack/pull/4640#discussion_r571964937
##########
File path:
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
##########
@@ -794,6 +798,33 @@ public boolean createFullClone(String cloneName,
ManagedObjectReference morFolde
return false;
}
+ private void setDiskProvsioningType(VirtualMachineRelocateSpec relocSpec,
ManagedObjectReference morDs,
+ Storage.ProvisioningType
diskProvisioningType) throws Exception {
+ if (diskProvisioningType == null){
+ return;
+ }
+ List<VirtualMachineRelocateSpecDiskLocator> relocateDisks =
relocSpec.getDisk();
+ List<VirtualDisk> disks = this.getVirtualDisks();
+ for (VirtualDisk disk: disks){
Review comment:
I haven't seen a case, but the getVirtualDisks() method returns a list,
so just being safe here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
