GutoVeronezi opened a new pull request #4668: URL: https://github.com/apache/cloudstack/pull/4668
### Description These tests were changing the value of an attribute in a protected static object at runtime instead of mocking the object. We discovered this problem when working with the docker build containers in https://github.com/khos2ow/cloudstack-deb-builder/pull/20. They were breaking the tests when building in the docker container. This PR intends to improve these tests to use actual mocks, instead of change the value at runtime with reflection, keeping the same behavior. Obs: The [DEB Builder](https://github.com/khos2ow/cloudstack-deb-builder) uses version 4.13 to test the container's building. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [x] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [x] Minor - [ ] Trivial ### How Has This Been Tested? The tests were been ran and the packages were built locally. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
