rhtyd commented on a change in pull request #4668:
URL: https://github.com/apache/cloudstack/pull/4668#discussion_r575032411
##########
File path:
plugins/ca/root-ca/src/test/java/org/apache/cloudstack/ca/provider/RootCAProviderTest.java
##########
@@ -133,17 +128,17 @@ public void testRevokeCertificate() throws Exception {
@Test
public void testCreateSSLEngineWithoutAuthStrictness() throws Exception {
- overrideDefaultConfigValue(RootCAProvider.rootCAAuthStrictness,
"_defaultValue", "false");
+ provider.rootCAAuthStrictness = Mockito.mock(ConfigKey.class);
+
Mockito.when(provider.rootCAAuthStrictness.value()).thenReturn(Boolean.FALSE);
final SSLEngine e = provider.createSSLEngine(SSLUtils.getSSLContext(),
"/1.2.3.4:5678", null);
- Assert.assertFalse(e.getUseClientMode());
Review comment:
That's essentially removing the test case, I would actually disable or
remove the test @GutoVeronezi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
