sureshanaparti commented on a change in pull request #4640:
URL: https://github.com/apache/cloudstack/pull/4640#discussion_r572623700
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -929,21 +933,24 @@ private String cloneVMforVvols(VmwareContext context,
VmwareHypervisorHost hyper
return vmdkFileBaseName;
}
- private String createVMFolderWithVMName(VmwareContext context,
VmwareHypervisorHost hyperHost, TemplateObjectTO template,
- VirtualMachineMO vmTemplate,
VolumeObjectTO volume, DatacenterMO dcMo, DatastoreMO dsMo,
- String searchExcludedFolders)
throws Exception {
+ private String createVMAndFolderWithVMName(VmwareContext context,
VmwareHypervisorHost hyperHost, TemplateObjectTO template,
+ VirtualMachineMO vmTemplate,
VolumeObjectTO volume, DatacenterMO dcMo, DatastoreMO dsMo,
+ String searchExcludedFolders)
throws Exception {
String vmdkName = volume.getName();
try {
ManagedObjectReference morDatastore = dsMo.getMor();
ManagedObjectReference morPool =
hyperHost.getHyperHostOwnerResourcePool();
ManagedObjectReference morCluster =
hyperHost.getHyperHostCluster();
- if (template.getSize() != null){
+ if (template.getSize() != null) {
_fullCloneFlag = volume.getSize() > template.getSize() ? true
: _fullCloneFlag;
}
if (!_fullCloneFlag) {
+ if (_diskProvisioningStrictness) {
+ throw new CloudRuntimeException("Unable to create linked
clones with strict disk provisioning enabled");
Review comment:
will fail here for both thin and thick disk provisioning, please check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
