sureshanaparti commented on a change in pull request #4640:
URL: https://github.com/apache/cloudstack/pull/4640#discussion_r572625459
##########
File path:
plugins/storage/volume/default/src/main/java/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java
##########
@@ -404,6 +406,12 @@ protected boolean createStoragePool(long hostId,
StoragePool pool) {
CreateStoragePoolCommand cmd = new CreateStoragePoolCommand(true,
pool);
final Answer answer = agentMgr.easySend(hostId, cmd);
if (answer != null && answer.getResult()) {
+ HypervisorType hyperVisorType = getHypervisorType(hostId);
+ if (pool.getPoolType() == StoragePoolType.NetworkFilesystem &&
hyperVisorType == HypervisorType.VMware) {
+ GetStoragePoolCapabilitiesCommand capsCmd = new
GetStoragePoolCapabilitiesCommand();
+ capsCmd.setPool(new StorageFilerTO(pool));
+ agentMgr.easySend(hostId, capsCmd);
Review comment:
not checking for the answer and updating the results from it ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
