Spaceman1984 commented on a change in pull request #4640:
URL: https://github.com/apache/cloudstack/pull/4640#discussion_r582897918
##########
File path:
engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
##########
@@ -179,9 +179,32 @@ public boolean configure(String name, Map<String, Object>
params) throws Configu
} else if(allocationAlgorithm.equals("firstfitleastconsumed")){
pools = reorderPoolsByCapacity(plan, pools);
}
+
+ // Hardware accelerated pools are preferred for thick disks
+ if (dskCh != null &&
!dskCh.getProvisioningType().equals(Storage.ProvisioningType.THIN) &&
Review comment:
If I move that into the method I have to pass in the plan as well. I
don't think it matters here. It will also impact the readability negatively as
there is already alot of logic hapening inside of that method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
