GabrielBrascher commented on pull request #4771: URL: https://github.com/apache/cloudstack/pull/4771#issuecomment-792790812
Anyway, I see one check that this PR does and #4698 does not. Which is checking if `srcVolumeInfo` is not null. However looking at the code, I don't see any way that it can be null. If `srcVolumeInfo` is null then we will see NPE previously on the caller, precisely at [StorageSystemDataMotionStrategy.java#L1806](https://github.com/apache/cloudstack/blob/a1be9b02a6cc2b629a29b6cd6a712e9254f4eaa0/engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java#L1806). With that said, I am +1 on @GutoVeronezi solution; he adds quite interesting log messages. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
