DaanHoogland commented on a change in pull request #4780:
URL: https://github.com/apache/cloudstack/pull/4780#discussion_r592157067
##########
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##########
@@ -2897,4 +2899,27 @@ private CopyCmdAnswer performCopyOfVdi(VolumeInfo
volumeInfo, SnapshotInfo snaps
return copyCmdAnswer;
}
+
+ protected Boolean supportStoragePoolType(StoragePoolType
storagePoolTypeToValidate, StoragePoolType... extraAcceptedValues) {
+ List<StoragePoolType> values = new ArrayList<>();
+
+ values.add(StoragePoolType.NetworkFilesystem);
+ values.add(StoragePoolType.SharedMountPoint);
Review comment:
is this true for all hypervisors/storage backends? I know this is a new
method only called from the KVMNonManaged, but that is not reflected in the
name or protected by encapsulation. (genuine question)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
