GabrielBrascher commented on pull request #4567: URL: https://github.com/apache/cloudstack/pull/4567#issuecomment-796780782
@GutoVeronezi thanks for rebasing and fixing the compilation issue. Answering your question: You had correctly addressed most of the callers by adding `LibvirtException e` at their respective `catch` blocks. However, it was missing LibvirtException at the cath block in `LibvirtComputingResource.java`. Therefore, the error that I reported was a compilation error caused due to the addition of `LibvirtException` at the method's _throws_ that was not handled at LibvirtComputingResource.java (lines 4304 and 4310). Commit that added the mentioned `LibvirtExeption`: https://github.com/apache/cloudstack/blob/1c1d3566827ba75e5cf17a1c6fe0789a959a501d/plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java#L352 I don't understand how commit https://github.com/apache/cloudstack/commit/db1e0f49dc06d16218ce61d9ef6a025075710d8e would introduce that error. At that time method `QemuImg.info` was not throwing `LibvirtException`. Additionally, checking at PR #4656 all looks good: Jenkins, Travis, and Trilian tests passed (https://github.com/apache/cloudstack/pull/4656/commits).  ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
