DaanHoogland commented on a change in pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#discussion_r601680079
##########
File path:
server/src/main/java/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java
##########
@@ -419,7 +419,9 @@ public VpnUser doInTransaction(TransactionStatus status) {
public boolean removeVpnUser(long vpnOwnerId, String username, Account
caller) {
final VpnUserVO user =
_vpnUsersDao.findByAccountAndUsername(vpnOwnerId, username);
if (user == null) {
- throw new InvalidParameterValueException("Could not find vpn user
" + username);
+ String errorMessage = String.format("Could not find VPN user=[%s].
VPN owner id=[%s]", username, vpnOwnerId);
+ s_logger.debug(errorMessage);
Review comment:
yes, please. to 3 by now. but as we don't use facadeproxy modules for
3rd party libraries that's not a trivial job and needs heavy sponsoring by
volunteers :togueincheek: :a.k.a.: :p
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
