shwstppr commented on a change in pull request #4816:
URL: https://github.com/apache/cloudstack/pull/4816#discussion_r602042673
##########
File path:
plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixHelper.java
##########
@@ -44,4 +45,14 @@ public static String getPVbootloaderArgs(String guestOS) {
}
return "";
}
+
+ public static String getSRNameLabel(final String poolUuid,
+ final Storage.StoragePoolType poolType,
+ final String poolPath) {
+ if (Storage.StoragePoolType.PreSetup.equals(poolType) &&
+ !poolPath.contains(poolUuid)) {
Review comment:
@DaanHoogland For presetup pools, UUID in DB is set as the path of the
pool (without `/`)
But in ACP it was using real UUIDs as reported in the linked issue.
So my change is just to use path (without `/`) when there is a mismatch
between path and UUID and the pool is of type presetup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]