DaanHoogland commented on a change in pull request #4816:
URL: https://github.com/apache/cloudstack/pull/4816#discussion_r603107039
##########
File path:
plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java
##########
@@ -96,6 +96,14 @@ public XenServerStorageProcessor(final CitrixResourceBase
resource) {
hypervisorResource = resource;
}
+ protected String getSRNameLabel(final PrimaryDataStoreTO primaryStore) {
+ if
(Storage.StoragePoolType.PreSetup.equals(primaryStore.getPoolType()) &&
+ !primaryStore.getPath().contains(primaryStore.getUuid())) {
+ return primaryStore.getPath().replace("/", "");
Review comment:
Yes, @shwstppr but different classes implementing the exact same doesn't
like right to me. It seems to me
1. the method should be a utility (easy dirty quick solution) or
2. the storage path should have it's own class that is referred from all
three users of the path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
