DaanHoogland commented on a change in pull request #4881:
URL: https://github.com/apache/cloudstack/pull/4881#discussion_r603934943
##########
File path:
server/src/main/java/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
##########
@@ -578,7 +578,7 @@ protected void runInContext() {
@Override
public Long getDelay() {
- return null;
+ return outOfBandManagementBackgroundTaskExecutionInterval.value()
* 1000L;
Review comment:
```suggestion
return
OutOfBandManagementBackgroundTaskExecutionInterval.value() * 1000L;
```
##########
File path:
api/src/main/java/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementService.java
##########
@@ -33,6 +33,9 @@
ConfigKey<Integer> SyncThreadPoolSize = new ConfigKey<Integer>("Advanced",
Integer.class, "outofbandmanagement.sync.poolsize", "50",
"The out of band management background sync thread pool size",
true, ConfigKey.Scope.Global);
+ ConfigKey<Integer> outOfBandManagementBackgroundTaskExecutionInterval =
new ConfigKey<>("Advanced", Integer.class,
"outofbandmanagement.background.task.execution.interval", "4",
Review comment:
```suggestion
ConfigKey<Integer> OutOfBandManagementBackgroundTaskExecutionInterval =
new ConfigKey<>("Advanced", Integer.class,
"outofbandmanagement.background.task.execution.interval", "4",
```
##########
File path:
server/src/main/java/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
##########
@@ -534,7 +534,7 @@ public String getConfigComponentName() {
@Override
public ConfigKey<?>[] getConfigKeys() {
- return new ConfigKey<?>[] {ActionTimeout, SyncThreadPoolSize};
+ return new ConfigKey<?>[] {ActionTimeout, SyncThreadPoolSize,
outOfBandManagementBackgroundTaskExecutionInterval};
Review comment:
```suggestion
return new ConfigKey<?>[] {ActionTimeout, SyncThreadPoolSize,
OutOfBandManagementBackgroundTaskExecutionInterval};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
