Pearl1594 commented on a change in pull request #4551:
URL: https://github.com/apache/cloudstack/pull/4551#discussion_r604615830
##########
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
##########
@@ -392,15 +405,16 @@ protected Answer copyVolumeBetweenPools(DataObject
srcData, DataObject destData)
return answer;
}
} catch (Exception e) {
- if (imageStore.exists(objOnImageStore)) {
+ if (objOnImageStore != null) {
Review comment:
imagestore.exists() eventually calls
volumeDataStoreDao.findByStoreVolume(...) for volumes, which in case of
multiple entries could possibly return the wrong record
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
