harikrishna-patnala commented on a change in pull request #4551:
URL: https://github.com/apache/cloudstack/pull/4551#discussion_r607034416
##########
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
##########
@@ -392,15 +405,16 @@ protected Answer copyVolumeBetweenPools(DataObject
srcData, DataObject destData)
return answer;
}
} catch (Exception e) {
- if (imageStore.exists(objOnImageStore)) {
+ if (objOnImageStore != null) {
Review comment:
@Pearl1594 what you are saying might be true but during catch() we have
to check if DB entry really exists or not and process the image storage object
by marking it OperationFailed. objOnImageStore will always be != null
(_"DataObject objOnImageStore = imageStore.create(srcData);"_) since no where
in try{} block we are setting to null or changing the object.
@DaanHoogland in that method we are dealing only with database entries. If
you are asking if it represents nothing on imagestore "physically" then the
answer is we don't need to be concerned about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
