GutoVeronezi commented on a change in pull request #4570:
URL: https://github.com/apache/cloudstack/pull/4570#discussion_r607246485
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
##########
@@ -288,6 +295,17 @@ Use VIR_DOMAIN_XML_SECURE (value = 1) prior to v1.0.0.
return new MigrateAnswer(command, result == null, result, null);
}
+ private int parseAgentPropertiesVmMigrateDomainRetrieveTimeout() throws
IOException {
+ final File agentPropertiesFile =
PropertiesUtil.findConfigFile(KeyStoreUtils.AGENT_PROPSFILE);
Review comment:
@weizhouapache I took a look into this class and I am a bit confused. It
seems like a facade of `PropertiesUtils` mixed with an another purpouse.
It seems to me that this class is badly structured, without a clear flow and
with nonsense logs. I think it will add a meaningless complexity to the code
instead of facility it.
In other hand, in PR https://github.com/apache/cloudstack/pull/4586 there is
a proposal of a handler that will simplify this code. If it be approved, I will
change this PR to use the handler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
