DaanHoogland commented on a change in pull request #4896:
URL: https://github.com/apache/cloudstack/pull/4896#discussion_r607702368
##########
File path: test/integration/smoke/test_kubernetes_clusters.py
##########
@@ -81,6 +82,20 @@ def setUpClass(cls):
"cloud.kubernetes.service.enabled",
"true")
cls.restartServer()
+ if cls.hypervisor.lower() == 'vmware':
+ cls.create_full_clone = Configurations.list(cls.apiclient,
name="vmware.create.full.clone")[0].value
+ if cls.create_full_clone not in ["true", True]:
+ Configurations.update(cls.apiclient,
+ "vmware.create.full.clone",
+ "true")
+ allStoragePools = StoragePool.list(
+ cls.apiclient
+ )
+ for pool in allStoragePools:
+ Configurations.update(cls.apiclient,
+ storageid=pool.id,
+ name="vmware.create.full.clone",
+ value="true")
Review comment:
I see the same code below, can you externalise this in a separate method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
