rhtyd commented on a change in pull request #4918:
URL: https://github.com/apache/cloudstack/pull/4918#discussion_r613829368
##########
File path: server/src/main/java/com/cloud/server/StatsCollector.java
##########
@@ -1020,14 +1020,18 @@ protected void runInContext() {
if (answer != null && answer.getResult()) {
storagePoolStats.put(pool.getId(),
(StorageStats)answer);
+ boolean poolNeedsUpdating = false;
// Seems like we have dynamically updated the pool
size since the prev. size and the current do not match
- if (pool.getCapacityBytes() !=
((StorageStats)answer).getCapacityBytes() ||
- pool.getUsedBytes() !=
((StorageStats)answer).getByteUsed()) {
+ if (_storagePoolStats.get(poolId) != null &&
_storagePoolStats.get(poolId).getCapacityBytes() !=
((StorageStats)answer).getCapacityBytes()) {
Review comment:
The code is reverted to how it was structured in 4.11.3; I suppose at
least the solidfire storage pool capacity wouldn't reset to 0. But good idea to
add some guarding (either for the 0 check or if the pool is solidfire).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
