slavkap commented on a change in pull request #4923:
URL: https://github.com/apache/cloudstack/pull/4923#discussion_r613979473
##########
File path: ui/src/views/AutogenView.vue
##########
@@ -983,13 +983,13 @@ export default {
continue
}
if (!input === undefined || input === null ||
- (input === '' && !['updateStoragePool', 'updateHost',
'updatePhysicalNetwork'].includes(action.api))) {
+ (input === '' && !['updateStoragePool', 'updateHost',
'updatePhysicalNetwork', 'updateDiskOffering',
'updateNetworkOffering'].includes(action.api))) {
if (param.type === 'boolean') {
params[key] = false
}
break
}
- if (!input) {
+ if (!input && !['tags'].includes(key)) {
Review comment:
@utchoang I left it like this `!['tags'].includes(key)` for future
fixes/enhancements if somebody wants to add parameters that could be an empty
text. If this is not acceptable, I could change it with your suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
