shwstppr commented on a change in pull request #4923:
URL: https://github.com/apache/cloudstack/pull/4923#discussion_r613945376
##########
File path: ui/src/views/AutogenView.vue
##########
@@ -983,13 +983,13 @@ export default {
continue
}
if (!input === undefined || input === null ||
- (input === '' && !['updateStoragePool', 'updateHost',
'updatePhysicalNetwork'].includes(action.api))) {
+ (input === '' && !['updateStoragePool', 'updateHost',
'updatePhysicalNetwork', 'updateDiskOffering',
'updateNetworkOffering'].includes(action.api))) {
if (param.type === 'boolean') {
params[key] = false
}
break
}
- if (!input) {
+ if (!input && !['tags'].includes(key)) {
Review comment:
@utchoang should we re-look this behaviour of skipping params that do
not have a value in API request.
It should be already handled by the `required` property of the parameter and
there can be some parameters that may allow passing empty text.
`!['tags'].includes(key)` should work same as `key !== 'tags`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
