CLOUDSTACK-3643: Automation: Fix wrong network acl rule for ping
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/6140be19 Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/6140be19 Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/6140be19 Branch: refs/heads/4.2 Commit: 6140be19882235816e3b844e3035e83d2d69ad6b Parents: 3de4390 Author: Sheng Yang <[email protected]> Authored: Sun Jul 21 19:40:10 2013 -0700 Committer: Sheng Yang <[email protected]> Committed: Sun Jul 21 22:21:17 2013 -0700 ---------------------------------------------------------------------- test/integration/component/test_vpc.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cloudstack/blob/6140be19/test/integration/component/test_vpc.py ---------------------------------------------------------------------- diff --git a/test/integration/component/test_vpc.py b/test/integration/component/test_vpc.py index c503be8..3a661d5 100644 --- a/test/integration/component/test_vpc.py +++ b/test/integration/component/test_vpc.py @@ -143,11 +143,11 @@ class Services: # Any network (For creating FW rule) "protocol": "TCP" }, - "http_rule": { - "startport": 80, - "endport": 80, + "icmp_rule": { + "icmptype": -1, + "icmpcode": -1, "cidrlist": '0.0.0.0/0', - "protocol": "TCP" + "protocol": "ICMP" }, "virtual_machine": { "displayname": "Test VM", @@ -1066,13 +1066,13 @@ class TestVPC(cloudstackTestCase): nwacl_internet_1 = NetworkACL.create( self.apiclient, networkid=network_1.id, - services=self.services["http_rule"], + services=self.services["icmp_rule"], traffictype='Egress' ) nwacl_internet_2 = NetworkACL.create( self.apiclient, networkid=network_2.id, - services=self.services["http_rule"], + services=self.services["icmp_rule"], traffictype='Egress' ) @@ -1411,13 +1411,13 @@ class TestVPC(cloudstackTestCase): nwacl_internet_1 = NetworkACL.create( self.apiclient, networkid=network_1.id, - services=self.services["http_rule"], + services=self.services["icmp_rule"], traffictype='Egress' ) nwacl_internet_2 = NetworkACL.create( self.apiclient, networkid=network_2.id, - services=self.services["http_rule"], + services=self.services["icmp_rule"], traffictype='Egress' )
