shwstppr commented on a change in pull request #4927:
URL: https://github.com/apache/cloudstack/pull/4927#discussion_r614706953



##########
File path: debian/rules
##########
@@ -38,7 +38,6 @@ override_dh_auto_install:
        mkdir $(DESTDIR)/$(SYSCONFDIR)/profile.d
        mkdir $(DESTDIR)/usr/share/$(PACKAGE)-agent
        mkdir $(DESTDIR)/usr/share/$(PACKAGE)-agent/plugins
-       install -D agent/target/cloud-agent-$(VERSION).jar 
$(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/$(PACKAGE)-agent.jar
        install -D 
plugins/hypervisors/kvm/target/cloud-plugin-hypervisor-kvm-$(VERSION).jar 
$(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/

Review comment:
       ```suggestion
        install -D 
plugins/hypervisors/kvm/target/cloud-plugin-hypervisor-kvm-$(VERSION).jar 
$(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/cloud-plugin-hypervisor-kvm-$(VERSION).jar
   ```
   @rhtyd build giving error,
   ```
   install -D 
plugins/hypervisors/kvm/target/cloud-plugin-hypervisor-kvm-4.15.1.0-SNAPSHOT.jar
 "debian/tmp"/usr/share/cloudstack-agent/lib/
   install: target 'debian/tmp/usr/share/cloudstack-agent/lib/' is not a 
directory: No such file or directory
   debian/rules:26: recipe for target 'override_dh_auto_install' failed
   ```
   Adding jar filename should fix this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to