sureshanaparti commented on a change in pull request #4924:
URL: https://github.com/apache/cloudstack/pull/4924#discussion_r614764382
##########
File path:
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/SnapshotDataFactoryImpl.java
##########
@@ -87,6 +87,9 @@ public SnapshotInfo getSnapshot(DataObject obj, DataStore
store) {
@Override
public SnapshotInfo getSnapshot(long snapshotId, DataStoreRole role) {
SnapshotVO snapshot = snapshotDao.findById(snapshotId);
+ if (snapshot == null) {
+ return null;
+ }
Review comment:
@DaanHoogland just check whether the 'null' returned here is being
verified or not wherever this method is called, to avoid any NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
