harikrishna-patnala commented on a change in pull request #4929:
URL: https://github.com/apache/cloudstack/pull/4929#discussion_r614784058
##########
File path:
plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
##########
@@ -3110,7 +3110,7 @@ private long getStaticMax(final String os, final boolean
b, final long dynamicMi
s_logger.warn("No recommended value found for dynamic max, setting
static max and dynamic max equal");
return dynamicMaxRam;
}
- final long staticMax = Math.min(recommendedValue, 4l * dynamicMinRam);
// XS
+ final long staticMax = Math.max(recommendedValue, 4L * dynamicMinRam);
// XS
Review comment:
4 times dynamicMinRam can be higher than the recommended value, so it
needs be min() only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
