shwstppr commented on a change in pull request #4929:
URL: https://github.com/apache/cloudstack/pull/4929#discussion_r619072402
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -1946,12 +1946,6 @@ private boolean upgradeRunningVirtualMachine(Long vmId,
Long newServiceOfferingI
_itMgr.reConfigureVm(vmInstance.getUuid(),
currentServiceOffering, newServiceOffering, customParameters,
existingHostHasCapacity);
success = true;
return success;
- } catch (InsufficientCapacityException e) {
- s_logger.warn("Received exception while scaling ", e);
- } catch (ResourceUnavailableException e) {
- s_logger.warn("Received exception while scaling ", e);
- } catch (ConcurrentOperationException e) {
- s_logger.warn("Received exception while scaling ", e);
} catch (Exception e) {
s_logger.warn("Received exception while scaling ", e);
Review comment:
@Pearl1594 sorry for the confusion but I was referring `catch (Exception
e)`. Do we really need that?
Anyway, not your change so I'm LGTM for this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
