[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4904: Adding VPN options for IKE version and IKE split connections.

Sun, 25 Apr 2021 22:12:43 -0700 


Pearl1594 commented on a change in pull request #4904:
URL: https://github.com/apache/cloudstack/pull/4904#discussion_r619974617



##########
File path: ui/src/views/network/CreateVpnCustomerGateway.vue
##########
@@ -317,7 +350,9 @@ export default {
           dpd: values.dpd,
           forceencap: values.forceencap,
           ikepolicy: ikepolicy,
-          esppolicy: esppolicy
+          esppolicy: esppolicy,
+          splitconnections: values.splitconnections,
+          ikeversion: values.ikeversion

Review comment:
       ```suggestion
             ikeversion: values.ikeVersions
   ```
   
   This causes ikeversion to be null at the time of creation of the customer 
gateway - as it isn't passed, hence defaults to ike
   
![image](https://user-images.githubusercontent.com/10495417/116030998-74c1a200-a67a-11eb-8473-9fa70b62d88f.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to