Pearl1594 commented on a change in pull request #4904:
URL: https://github.com/apache/cloudstack/pull/4904#discussion_r619974617
##########
File path: ui/src/views/network/CreateVpnCustomerGateway.vue
##########
@@ -317,7 +350,9 @@ export default {
dpd: values.dpd,
forceencap: values.forceencap,
ikepolicy: ikepolicy,
- esppolicy: esppolicy
+ esppolicy: esppolicy,
+ splitconnections: values.splitconnections,
+ ikeversion: values.ikeversion
Review comment:
```suggestion
ikeversion: values.ikeVersions
```
This causes ikeversion to be null at the time of creation of the customer
gateway - as it isn't passed, hence defaults to ike
##########
File path: ui/src/config/section/network.js
##########
@@ -611,7 +611,7 @@ export default {
label: 'label.edit',
docHelp:
'adminguide/networking_and_traffic.html#updating-and-removing-a-vpn-customer-gateway',
dataView: true,
- args: ['name', 'gateway', 'cidrlist', 'ipsecpsk', 'ikepolicy',
'ikelifetime', 'esppolicy', 'esplifetime', 'dpd', 'forceencap']
+ args: ['name', 'gateway', 'cidrlist', 'ipsecpsk', 'ikepolicy',
'ikelifetime', 'ikeversion', 'esppolicy', 'esplifetime', 'dpd',
'splitconnections', 'forceencap']
Review comment:
```suggestion
args: ['name', 'gateway', 'cidrlist', 'ipsecpsk', 'ikepolicy',
'ikelifetime', 'ikeversion', 'esppolicy', 'esplifetime', 'dpd',
'splitconnections', 'forceencap'],
mapping: {
ikeversion: {
options: ['ike', 'ikev1', 'ikev2']
}
}
```
To list the ike versions during the update operation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
