GabrielBrascher commented on a change in pull request #4967:
URL: https://github.com/apache/cloudstack/pull/4967#discussion_r623069029
##########
File path: engine/schema/src/main/java/com/cloud/vm/VMInstanceVO.java
##########
@@ -200,7 +200,7 @@
@Column(name = "backup_external_id")
protected String backupExternalId;
- @Column(name = "backup_volumes")
+ @Column(name = "backup_volumes", length = 65535)
Review comment:
That sounds like a plan @olivierlemasle :+1:
Let me be clear that I am not **-1** if you keep it as it is right now. But
I think that it could be interesting to avoid "magical" numbers for length.
I see that normalizing column length values to constants/Enum is the kind of
enhancement that might need to be addressed on a PR of its own; therefore, I
would not be **-1** with your proposal as it is right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
