rhtyd commented on a change in pull request #4976:
URL: https://github.com/apache/cloudstack/pull/4976#discussion_r623639918
##########
File path: setup/bindir/cloud-setup-databases.in
##########
@@ -443,7 +444,7 @@ for example:
self.encryptiontype = self.options.encryptiontype
self.mgmtsecretkey = self.options.mgmtsecretkey
- self.dbsecretkey = self.options.dbsecretkey
+ self.dbsecretkey = shlex.quote(self.options.dbsecretkey)
Review comment:
@Spaceman1984 this adds a quote to the string, why do we want to add
that? Are we passing it as a parameter to something on shell?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
