sureshanaparti commented on a change in pull request #5002:
URL: https://github.com/apache/cloudstack/pull/5002#discussion_r629933445
##########
File path:
engine/schema/src/main/java/com/cloud/storage/dao/VMTemplateDaoImpl.java
##########
@@ -580,21 +524,6 @@ public void saveDetails(VMTemplateVO tmpl) {
* StringBuilder templateHostRefJoin = new StringBuilder(); String
* dataCenterJoin = "", lpjoin = ""; String tagsJoin = "";
*
- * if (isIso && !hyperType.equals(HypervisorType.None)) { guestOSJoin =
- * " INNER JOIN guest_os guestOS on (guestOS.id = t.guest_os_id) INNER
JOIN guest_os_hypervisor goh on ( goh.guest_os_id = guestOS.id) "
- * ; } if (onlyReady){ templateHostRefJoin.append(
- * " INNER JOIN template_host_ref thr on (t.id = thr.template_id) INNER
JOIN host h on (thr.host_id = h.id)"
- * ); sql = SELECT_TEMPLATE_HOST_REF; groupByClause =
- * " GROUP BY t.id, h.data_center_id "; } if ((templateFilter ==
- * TemplateFilter.featured) || (templateFilter ==
TemplateFilter.community))
- * { dataCenterJoin =
- * " INNER JOIN data_center dc on (h.data_center_id = dc.id)"; }
- *
- * if (zoneType != null) { dataCenterJoin =
- * " INNER JOIN template_host_ref thr on (t.id = thr.template_id) INNER
JOIN host h on (thr.host_id = h.id)"
- * ; dataCenterJoin +=
- * " INNER JOIN data_center dc on (h.data_center_id = dc.id)"; }
- *
Review comment:
this comment can be completely removed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
