rhtyd commented on a change in pull request #5014:
URL: https://github.com/apache/cloudstack/pull/5014#discussion_r630095411
##########
File path: ui/package.json
##########
@@ -24,9 +24,11 @@
"url": "https://github.com/apache/cloudstack/issues";
},
"scripts": {
+ "prebuild": "./prebuild.sh",
Review comment:
@shwstppr could relative paths cause any issue? For ex. break in deb/rpm
builds?
##########
File path: ui/package.json
##########
@@ -24,9 +24,11 @@
"url": "https://github.com/apache/cloudstack/issues";
},
"scripts": {
+ "prebuild": "./prebuild.sh",
"start": "vue-cli-service lint --no-fix && vue-cli-service serve",
"serve": "vue-cli-service lint --no-fix && vue-cli-service serve",
"build": "vue-cli-service build",
+ "postbuild": "./postbuild.sh",
Review comment:
@shwstppr could relative paths cause any issue? For ex. break in deb/rpm
builds?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
