shwstppr commented on a change in pull request #5020:
URL: https://github.com/apache/cloudstack/pull/5020#discussion_r630943472
##########
File path: ui/src/views/infra/network/TrafficTypesTab.vue
##########
@@ -129,6 +140,35 @@ export default {
}).finally(() => {
this.fetchLoading = false
})
+
+ this.fetchLoading = true
+ api('listZones', { id: this.resource.zoneid }).then(json => {
+ const zone = json.listzonesresponse.zone || []
+ this.networkType = zone[0].networktype
+ }).catch(error => {
+ this.$notifyError(error)
+ }).finally(() => {
+ this.fetchLoading = false
+ })
+ },
+ fetchGuestNetwork () {
+ if (this.networkType === 'Basic') {
Review comment:
@Pearl1594 Can you please check if this even called. Default value for
`networkType` is `Advanced` and `fetchGuestNetwork` is called before finding
`networkType` at line 147. I think `network` object of IpRangesTabPublic.vue
will always remain empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
