Pearl1594 commented on pull request #5017: URL: https://github.com/apache/cloudstack/pull/5017#issuecomment-842581546
@olivierlemasle Thanks for the review. With respect to your concern regarding usage_backup records not being marked as removed for destroyed VMs (with no backups) - in commit d3de10e47c8cfd5dbe155c42b7b715a1e6ed5ec1, usage records for VM's that are destroyed with no backups are prevented by disassociating the backup offering from the VM - while this seemed appropriate while testing against Dummy backup Provider, on discussion with @rhtyd it was understood that since veeam, an external entity, handles the backup job, though we may unassign the offering from the VM from ACS end, thus preventing further generation of usage records, it may still be active on the Provider (Veeam) end - in case a recurring schedule has been set up, which MAY have an adverse effect. Hence, the current solution has been proposed which will prevent usage record generation if the backup size is 0. I don't think we would lose usage records if `usage.stats.job.aggregation.range` < `backup.framework.sync.interval`, as I had tested (with the dummy backup provider) with `usage.stats.job.aggregation.range` = 2mins and `backup.framework.sync.interval` = 5mins. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
