Pearl1594 commented on a change in pull request #5017:
URL: https://github.com/apache/cloudstack/pull/5017#discussion_r636624327
##########
File path: engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java
##########
@@ -613,7 +613,7 @@ boolean ifStateUnchanged(State oldState, State newState,
Long oldHostId, Long ne
if (backupOfferingId != null) {
sc.setParameters("backup_offering_id", backupOfferingId);
}
- return listBy(sc);
+ return listIncludingRemovedBy(sc);
Review comment:
@shwstppr It is expected for usage events to be published for VMs that
are destroyed as long as there are backups available for that VM - which is
checked by the backupsize - i.e., only if backup size > 0 will
`EVENT_VM_BACKUP_USAGE_METRIC` event be published .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
