sureshanaparti commented on a change in pull request #5029:
URL: https://github.com/apache/cloudstack/pull/5029#discussion_r634378119



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -6208,8 +6208,8 @@ public VirtualMachine 
migrateVirtualMachineWithVolume(Long vmId, Host destinatio
             }
         }
 
-        if (!capabilities.isStorageMotionSupported()) {
-            throw new CloudRuntimeException("Migration with storage isn't 
supported on hypervisor " + srcHost.getHypervisorType() + " of version " + 
srcHost.getHypervisorVersion());
+        if (capabilities == null || !capabilities.isStorageMotionSupported()) {

Review comment:
       @slavkap when capabilities == null, it might be better to throw relevant 
message, something like "Cannot migrate VM with storage, as the capabilities 
are not found for the hypervisor X with version 1".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to